Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the policy provider and factory to the JDK 11 compatible variant. #641

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

arjantijms
Copy link
Contributor


name: Pull Request
about: Create a pull request for a Platform TCK change
title: 'Update the policy provider and factory to the JDK 11 compatible variant.'
labels: '9.1'
assignees: ''


Fixes Issue
Specify the issue (link) that is solved with this pull request.

Related Issue(s)
Specify any related issue(s) links.

Describe the change
GlassFish contained two policy providers (authorization modules). 1 that contained large amounts of code copied from the JDK, with many references to sun.* packages. Another one that didn't. The first one is not JDK 11 compatible, while the second one is. This PR changes the policy provider and factory to use the JDK 11 compatible one.

Additional context
https://www.eclipse.org/lists/glassfish-dev/msg00976.html

CC @alwin-joseph @anajosep @arjantijms @cesarhernandezgt @dblevins @m0mus @edbratt @gurunrao @jansupol @jgallimore @kazumura @kwsutter @LanceAndersen @bhatpmk @RohitKumarJain @shighbar @gthoman

Signed-off-by: arjantijms arjan.tijms@gmail.com

Signed-off-by: arjantijms <arjan.tijms@gmail.com>
@gurunrao
Copy link
Contributor

gurunrao commented Mar 9, 2021

All JACC TCK tests are passing, with PR changes.
JDK8 + GF 6 + PR - https://ci.eclipse.org/jakartaee-tck/job/guru/job/jakartaeetck-policyprovider/job/policyprovider/4/
JDK11 + GF6.1 + PR - https://ci.eclipse.org/jakartaee-tck/job/guru/job/jakartaeetck-policyprovider/job/policyprovider/5/
Thanks for helping with fix.

@scottmarlow scottmarlow merged commit 98fa8e8 into jakartaee:master Mar 9, 2021
@arjantijms arjantijms deleted the policyprovider branch May 28, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9.1 9.1 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants