EntityManager(Factory) should implement AutoCloseable

[lukasj]

EntityManager and EntityManagerFactory have #close() methods but do not implement AutoCloseable. Implementing AutoCloseable would allow them to be used in Java 7 try-with-resource statement.

[lukasj]

@glassfishrobot Commented
Reported by braghest

[lukasj]

@glassfishrobot Commented
flutter said:
This would mean to drop Java 6 support, right?

[lukasj]

@glassfishrobot Commented
braghest said:
That would mean dropping Java 7 support but then again Java EE 7 requires Java SE 7.

[lukasj]

@glassfishrobot Commented
neilstockton said:
It would mean dropping Java 1.6, yes. But then Java 1.6 and Java 1.7 are BOTH end of life now.
By the time the next version of JPA happens (who knows when that is), Java 1.8+ should be the baseline, hence no reason why this issue can't be included.
+1

[lukasj]

@glassfishrobot Commented
jemiller1 said:
Come on guys. It's 2016 and Java 8 has been out for over a year. Is this ever going to get implemented? It looks really obvious to me that this needs to happen. I don't know what to say about the whole Java standards process other than it's extremely slow. Coming from a .NET environment. It is a huge step backwards working with Java. I'm amazed that things as simple as this don't just work. And has already been pointed out Java 6 and 7 are already EOL.

[lukasj]

@glassfishrobot Commented
s.grinovero said:
For the record, we had this in Hibernate since a while, and initially implemented java.io.Closeable which just requires java 1.5. java.io.Closeable extends AutoCloseable since Java 7, so people on Java >=7 could use the try-with-resources pattern already.

[lukasj]

@glassfishrobot Commented
This issue was imported from java.net JIRA JPA_SPEC-77

[lukasj]

@KrishnaST Commented
2018 and counting.

[lukasj]

• Issue Imported From: https://github.com/javaee/jpa-spec/issues/77
• Original Issue Raised By:@glassfishrobot
• Original Issue Assigned To: Unassigned

[MalteMagnussen]

I've been working a lot with EntityManager in school now, and it kinda bugs me that this isn't implemented.
It isn't a big deal though, I just add a finally { em.close } to all my stuff, but it would be lovely if we could use try-with-resources.
Please get this implemented.

[nerdglitchtiff]

It would be great if we could use the try-with-resource statement with the EntityManager Factory Interface. It's the only thing that makes sense.

[gavinking]

+1

[joeltoby]

+1

[DSEyers]

+1