Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove raw types warnings with Class #5133

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

Emkas
Copy link
Contributor

@Emkas Emkas commented Jun 24, 2022

No description provided.

@Emkas
Copy link
Contributor Author

Emkas commented Jun 24, 2022

Hmm... this is odd. Build failed. I use mvn clean install and all looks fine. Now I even did what fails in a build mvn --no-transfer-progress install -Pstaging and it ends fine as well. I there any command I should look for?

BTW. Shouldn't this be mvn clean --no-transfer-progress install -Pstaging?

Edit: all is good now.

@BalusC
Copy link
Contributor

BalusC commented Jun 25, 2022

This PR is too big to quickly glance over, but I see that this change also affected the public API at a handful places (i.e. these changes basically also affect the generated javadocs). I recommend to not do that in the context of this PR.

It should ideally be done via a faces spec issue ticket where spec maintainers can chime into the discussion.

@Emkas Emkas force-pushed the raw-types-with-class branch from 6c8611c to c5160c9 Compare June 28, 2022 12:09
@Emkas
Copy link
Contributor Author

Emkas commented Jun 28, 2022

OK. PR is still big. If you want to to split, please tell me.

I removed everything what is touching public methods/fields etc.

@Emkas Emkas force-pushed the raw-types-with-class branch from c5160c9 to 624cdc2 Compare June 28, 2022 12:17
Signed-off-by: Emil Sierżęga <emilsierzega@gmail.com>
@Emkas Emkas force-pushed the raw-types-with-class branch from 624cdc2 to 6dce606 Compare June 29, 2022 08:27
@BalusC BalusC merged commit be054fd into eclipse-ee4j:master Jun 29, 2022
@Emkas Emkas deleted the raw-types-with-class branch June 29, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants