Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mocks clean up #5146

Merged
merged 7 commits into from
Jun 30, 2022
Merged

Mocks clean up #5146

merged 7 commits into from
Jun 30, 2022

Conversation

Emkas
Copy link
Contributor

@Emkas Emkas commented Jun 30, 2022

No description provided.

@Emkas
Copy link
Contributor Author

Emkas commented Jun 30, 2022

After this PR I will be able to say that I reduced number of warnings by half. (Only 1,2 k left 👯)

@BalusC BalusC merged commit 0972295 into eclipse-ee4j:master Jun 30, 2022
@BalusC
Copy link
Contributor

BalusC commented Jun 30, 2022 •
edited
Loading

Build failed after merge: https://github.com/eclipse-ee4j/mojarra/runs/7129295931?check_suite_focus=true#step:4:1585

Error: COMPILATION ERROR :
[INFO] -------------------------------------------------------------
Error: /home/runner/work/mojarra/mojarra/impl/src/test/java/jakarta/faces/component/NamingContainerTestCase.java:[66,48] incompatible types: java.util.Map<capture#1 of ?,capture#2 of ?> cannot be converted to java.util.Map<java.lang.String,java.lang.String>

Can you take a look?

@Emkas
Copy link
Contributor Author

Emkas commented Jun 30, 2022

Sure. Sorry, I thought I run mvn clean install...

@BalusC
Copy link
Contributor

BalusC commented Jun 30, 2022

Most probably not upmerged with most recent from master before PR was merged. Currently the source branch says it is 3 commits behind master.

@Emkas Emkas deleted the mocks-clean-up branch June 30, 2022 12:55
@Emkas Emkas mentioned this pull request Jun 30, 2022
Merged
@Emkas
Copy link
Contributor Author

Emkas commented Jun 30, 2022

Fixed in #5147.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Emkas @BalusC