Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused constants for com.sun.faces.* context params #5332

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Remove unused constants for com.sun.faces.* context params #5332

merged 1 commit into from
Oct 21, 2023

Conversation

BalusC
Copy link
Contributor

@BalusC BalusC commented Oct 14, 2023

@BalusC BalusC requested review from arjantijms and mnriem October 14, 2023 18:11
@BalusC BalusC added the 4.0 label Oct 14, 2023
@BalusC BalusC added this to the 4.0.5 milestone Oct 14, 2023
mnriem
mnriem approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@mnriem mnriem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BalusC BalusC merged commit e2907ab into 4.0 Oct 21, 2023
2 checks passed
@BalusC BalusC deleted the mojarra_issue_5331_remove_unused_constants_for_mojarra_context_params branch October 28, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnriem mnriem mnriem approved these changes

@arjantijms arjantijms Awaiting requested review from arjantijms

Assignees
No one assigned
Labels
4.0
Projects
None yet
Milestone
4.0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@BalusC @mnriem