Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add session mutex #5393

Merged
merged 4 commits into from
Mar 2, 2024
Merged

Add session mutex #5393

merged 4 commits into from
Mar 2, 2024

Conversation

BalusC
Copy link
Contributor

@BalusC BalusC commented Feb 10, 2024

@BalusC BalusC added this to the 4.0.6 milestone Feb 10, 2024
mnriem
mnriem approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@mnriem mnriem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but would have loved to see a test. It is a bit weird that the HttpSession object changes and it feels like a hack.

@BalusC
Copy link
Contributor Author

BalusC commented Feb 17, 2024

Mojarra doesn't anymore have IT env (everything has been moved to Faces/TCK) and current UT env is super outdated with JUnit4/Easymock/Powermock, should become JUnit5/Mockito.

@BalusC BalusC merged commit e727ed4 into 4.0 Mar 2, 2024
3 checks passed
@BalusC BalusC deleted the mojarra_issue_5380_add_session_mutex branch March 2, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnriem mnriem mnriem approved these changes

@jasondlee jasondlee jasondlee approved these changes

@arjantijms arjantijms Awaiting requested review from arjantijms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.6
Development

Successfully merging this pull request may close these issues.
3 participants
@BalusC @jasondlee @mnriem