Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PartialViewContextImpl should use same VisitContext to reset values as the one used to process the execute and render #5397

Merged
merged 3 commits into from
Mar 2, 2024

Conversation

BalusC
Copy link
Contributor

@BalusC BalusC commented Feb 10, 2024

@BalusC
Copy link
Contributor Author

BalusC commented Feb 10, 2024

cc: @tandraschko

@tandraschko
Copy link
Contributor

+1 but do we really need EXECUTE_LIFECYCLE? AFAICS its not used in our IMPLs but the MF javadoc says something like

     * Hint that indicates that the visit is being performed as part of
     * lifecycle phase execution and as such phase-specific actions
     * (initialization) may be taken.

if i reset something, i dont want to trigger "initialization" of something

@tandraschko
Copy link
Contributor

currently it's only used for partial processing the tree, i dont think we should use it for resetting components

@BalusC
Copy link
Contributor Author

BalusC commented Feb 17, 2024

Fair point, adjusted.

@tandraschko
Copy link
Contributor

nice!

@BalusC
Do you have already plans to merge this and release 4.0.6?
I would like to have a release, so we can further work on DeltaSpike integration tests as they currently failing because of the other PR encoding/encodeRedirectUrl thing which is already fixed and merged

@BalusC BalusC merged commit 5d700b3 into 4.0 Mar 2, 2024
3 checks passed
@BalusC BalusC deleted the mojarra_issue_5396_fix_partial_process_of_reset_values branch March 2, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants