Get loader-classname lock for calls to findLoadedClass #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is related to Open J9 issue eclipse-openj9/openj9#20444 There is a concern that the initial call to findLoadedClass by Equinox is not protected by the same loader-classname lock as the later calls to findLoadedClass/defineClass are. There are concerns that the unprotected findLoadedClass call could catch the JVM in an invalid state if there is another thread in the middle of defining the class. This change replaces the clunky way of doing loader-classname locks with a more efficient strategy. This way we can use this lock around the initial call to findLoadedClass without too much concern over the performance impact. This change also removes some of the old code that still supported Java 6. It is always assumed we now can register the class loaders as parallel capable.
tjwatson
force-pushed
the
improveLoaderLock
branch
from
44c1d63
to
ca6eebf
Compare
Test Results 663 files + 3 663 suites +3 1h 17m 15s ⏱️ -49s For more details on these failures, see this check. Results for commit beb4c97. ± Comparison against base commit 2815608. ♻️ This comment has been updated with latest results. |
The following methods can stop throwing IllegalStateExceptions Bundle.uninstall BundleContext.createFilter BundleContext.getBundle BundleContext.getProperty BundleContext.removeServiceListener BundleContext.removeBundleListener BundleContext.removeFrameworkListener BundleContext.ungetService ServiceObjects.ungetService ServiceRegistration.unregister
|
Closing this PR to create a new one. Something got mixed up with the branches. I tried to force push back to the original, but still has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.