Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add baseline check to Tycho build #16

Closed
vogella opened this issue Apr 1, 2022 · 7 comments
Closed

Add baseline check to Tycho build #16

vogella opened this issue Apr 1, 2022 · 7 comments
Assignees

Comments

@vogella
Copy link
Contributor

vogella commented Apr 1, 2022

Maven Tycho supports since a while to run a API baseline check. We should enable this so that we do not break GEF consumers unintentional.

@azoitl
Copy link
Contributor

azoitl commented Apr 1, 2022

I would like to take over this task. However I must confess I would first need to read a bit on that. Do you have a pointer for me where to start?

@azoitl
Copy link
Contributor

azoitl commented Apr 3, 2022

Nevermind, after some more googeling and reading I think I know what needs to be done. Working on a first pull request.

@vogella
Copy link
Contributor Author

vogella commented Apr 4, 2022

Can you send a PR? Would be nice to have this in ASAP

@vogella
Copy link
Contributor Author

vogella commented Apr 4, 2022

Done via 8769f0a Thanks @azoitl

@vogella vogella closed this as completed Apr 4, 2022
@azoitl
Copy link
Contributor

azoitl commented Apr 4, 2022

I have the patch ready [1]. But messed up my GIT. Therefore I would need the pull request for issue #8 merged first if that is not to big of a problem.

[1] https://github.com/azoitl/gef-classic/tree/BaselineCheck

@azoitl
Copy link
Contributor

azoitl commented Apr 4, 2022

Ok now I'm confused. How did you get my patch? Still struggling with this strange github workflow.

@vogella
Copy link
Contributor Author

vogella commented Apr 4, 2022

You seem to have added it to #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants