Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 261662 - interface IEntityStyleProvider pulls in dependency on org.eclipse.ui.workbench #609

Open
ptziegler opened this issue Nov 4, 2024 · 1 comment
Labels
zest Issue related to the Zest component

Comments

@ptziegler
Copy link
Contributor

Based on https://bugs.eclipse.org/bugs/show_bug.cgi?id=261662.

Build ID: GEF-zest-sdk-3.5.0M4

Steps To Reproduce:
Download Zest examples, disable dependency to org.eclipse.ui.workbench and run any of the JFace snippets. They will fail with a NoClassDefFoundError, because of missing dependency to IDisposable:

java.lang.NoClassDefFoundError: org/eclipse/ui/services/IDisposable

IEntityStyleProvider is used e.g. in class GraphItemStyler, which in turn is used in class AbstractStylingModelFactory.

More information:
I would like to use Zest in a pure SWT/JFace or even Swing application, which should be possible, as there are working examples even in Zest source code (ok, the SimpleSWTExample needs org.eclipse.core.commands and org.eclipse.equinox.common, but that is just the example). When using JFace viewers, IEntityStyleProvider pulls in a dependency on org.eclipse.ui.services.IDisposable, which is contained in plugin/jar org.eclipse.ui.workbench_.jar. Requiring 4MB of code for a single interface qualifies as a bug in may opinion...

@ptziegler
Copy link
Contributor Author

This means Zest can't be used in a pure E4 environment. Note that removing the IDisposable interface breaks API, so we'd have to do so when updating Zest Core to 2.0

@ptziegler ptziegler added the zest Issue related to the Zest component label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
zest Issue related to the Zest component
Projects
None yet
Development

No branches or pull requests

1 participant