Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Duplicate Key Binding Triggers on WebKit #97

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

N1k145
Copy link
Contributor

@N1k145 N1k145 commented Apr 29, 2024

Fixes eclipse-glsp/glsp#874
Without this fix there are duplicated Key Binding Triggers on WebKit as the fix provided by BrowserKeyBindingForwarderInstaller is only an Issue on Chrome and Edge

What it does

Fixes Duplicate Key Binding Triggers on WebKit

How to test

Start the example on Windows and Linux,
Set the Focus in the Web browser View
Make sure that in both cases, Ctrl+H opens the Eclipse Search once.

Changelog

  • This PR should be mentioned in the changelog
  • This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)

Without this fix there are duplicated Key Binding Triggers on WebKit as the fix provided by BrowserKeyBindingForwarderInstaller is only an Issue on Chrome and Edge
@N1k145 N1k145 marked this pull request as draft April 30, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undo/redo is via shortcut is triggers multiple actions
1 participant