-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce hover tests and context menu #9
Conversation
- Rename deselect to select in GLSPGraph
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot.
Code looks good to me and works great. Only a few minor comments.
@@ -43,6 +43,14 @@ The following libraries/frameworks need to be installed on your system: | |||
- [Node.js](https://nodejs.org/en/) `>=16.11.0` | |||
- [Yarn](https://classic.yarnpkg.com/en/docs/install#debian-stable) `>=1.7.0` | |||
|
|||
## Min versions | |||
|
|||
- [Standalone](https://github.com/eclipse-glsp/glsp-client): v2.1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can leave this in for now, but should remove it once glsp-playwright is part of the general glsp release train (eclipse-glsp/glsp#1267).
Once that is the case it pretty self explantory that a specific version of glsp-playwright is compatible with the exact same version of the client/integration packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What we should add instead here is the minimum required VS Code version. I assume since the newest version changed the dom for the file explorer the tests no longer with older versions right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good point. Maybe we should also lock the VS Code instance to a specific version - right now it always downloads the newest version.
…sion, small clean ups
Thanks! We will have some failing tests as the latest released version of GLSP (2.1.1) doesn't have the fixes to the bugs found here. I will introduce in a separate PR a script that will setup the different repositories automatically, so that we can work with the latest version in master. |
👍🏼 Could you pleas list the tests which are expected to fail for now? |
For GLSP-Client 2.1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM!
What it does
waitForCreation
)skipIntegration
calledskipNonIntegration
, which does the opposite.Works on eclipse-glsp/glsp#1287
How to test
Tested with GLSP v2.1.1.
yarn test
.Follow-ups
Bug found
examples/workflow-test/tests/features/validation/marker.spec.ts
The marker › should be still visible after resizing
failing for all integrations.Steps:
Changelog
Renames:
deselect
inGLSPGraph
has been renamed tofocus
.