Refactorings: Source model loading and saving #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tortmayr
approved these changes
Mar 25, 2022
| try { | ||
| const data = this.modelSerializer.createSchema(this.modelState.root); | ||
| // eslint-disable-next-line no-null/no-null | ||
| writeFileSync(this.modelState.sourceUri!, JSON.stringify(data, null, 2)); |
There was a problem hiding this comment.
Instead of disabling the eslint rule you can just use undefined here instead of null
Suggested change
| writeFileSync(this.modelState.sourceUri!, JSON.stringify(data, null, 2)); | |
| writeFileSync(this.modelState.sourceUri!, JSON.stringify(data, undefined, 2)); |
There was a problem hiding this comment.
Ah right, yeah I just moved the code. I amended your change. Thanks!
- Rename ModelSourceLoader to SourceModelPersistence - Add saving to the SourceModelPersistence interface - Delegate from the SaveModelActionHandler to that implementation - Update javadoc and variable names where fit eclipse-glsp/glsp#582
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eclipse-glsp/glsp#582