-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add electron example app #211
Conversation
cf3606d
to
96eab63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good to me and I can open the Electron app and switch between Electron and Browser without issues. Thank you Tobias! I only noticed two things which may or may not be fixed as part of this PR:
-
The toolbox styling is customized for Theia but I'm not sure we want all of them. If we do it is fine and we definitely want to use Theia color variables etc. But could you please double check whether all the Theia tool palette styling is as it should be.
-
The grid does not work in the Electron case. It does work for the browser but I believe something does work and this stands out:
stroke="color-mix(in srgb, %23000000 10%, transparent)"
. This might be "fixed" with View improvements glsp-client#364 and some minor adaptations though, what do you think?
91c1ba2
to
b640eed
Compare
Thanks for the review @martin-fleck-at .
I also sneaked in a minor improvement to the |
63c2f90
to
1848cb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the quick update! I can confirm that the toolbox now looks nicer again and that the grid works in all themes. Great work, thank you, Tobias!
- Add an electron example app in addition to the browser app. This allows use to also test the electron use case and makes it easier to discover electron specific issues. - Adapt the build scripts to the same convention as used in the Theia repository. - yarn (install) only compiles the ts sources but does not build any example app - Example apps have to be built explicitly with `yarn browser build` or `yarn electron build` - Rename glsp debug arugment to avoid clashes with nodes debug argument - Update readmes and launch configs - Update Jenkins file - Update grid and tool palette styling - Update example1.wf - Allow reuse of `createDiagramWidgetFactory` for custom diagram widget - Add temporary workaround to remove @vscode/ripgrep postinstall script which often fails the build to rate limits. Can be removed once we have access to the github token in the ci. i.e. switch to GH actions
What it does
yarn browser build
oryarn electron build
How to test
Build the the electron app
eg:
yarn && yarn electron build
Then test the different connection scenarions
yarn electron start
yarn electron start:ws
yarn electron start:debug
yarn electron start:ws:debug
yarn electron start:integrated
Follow-ups
Changelog