Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Diagram" Menu to vscode glsp editor #201

Closed
tortmayr opened this issue Mar 24, 2021 · 1 comment
Closed

Add "Diagram" Menu to vscode glsp editor #201

tortmayr opened this issue Mar 24, 2021 · 1 comment
Labels
enhancement New feature or request vscode

Comments

@tortmayr
Copy link
Contributor

In the Theia integration we have a custom diagram menu to trigger certain actions on the diagram:
Screenshot from 2021-03-24 09-38-36

We should implement something similar for VS Code. As far as I know it is not possible to contribute new Menus directly to the main menu bar like we do it in Theia. So we have to look for a workaround.

Looking at the available contribution points the following entry points seem to be good candidates:

  • The editor context menu - editor/context
  • The editor title menu bar - editor/title
  • The editor title context menu - editor/title/context
@lforst
Copy link

lforst commented Oct 7, 2021

PR eclipse-glsp/glsp-vscode-integration#15 introduced a menu using editor/title as proposed. Additionally a submenu was added in the editor/title menu. This submenu can be found when the three dots in the upper right corner of the editor are pressed:

Recording.mov

As this issue outlines, it is currently not possible to implement items for the main menu bar. This implementation however, is as close as possible to this requirement.

Taking all of the above into account, I would consider this issue as resolved.

@tortmayr tortmayr closed this as completed Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vscode
Projects
None yet
Development

No branches or pull requests

2 participants