Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal Example Build Does Not Work, fails on yarn #248

Closed
dynamic-modeller opened this issue Jun 2, 2021 · 9 comments
Closed

Minimal Example Build Does Not Work, fails on yarn #248

dynamic-modeller opened this issue Jun 2, 2021 · 9 comments
Assignees
Projects

Comments

@dynamic-modeller
Copy link

Running through the minimal example in the glsp-examples repo, using Debian Linux (Windows Subsystem Linux - WSL), the build will not complete.

Using steps from this link https://github.com/eclipse-glsp/glsp-examples#building-the-minimal-example. The maven install works correctly cd server/org.eclipse.glsp.example.minimal && mvn clean install && cd ../..

The following yarn install does not complete and errors out cd client && yarn && cd ..

The terminal trace from these two commands is attached below
glspRepoYarnError.txt

@planger planger added this to New in GLSP kanban via automation Jun 2, 2021
@planger
Copy link
Member

planger commented Jun 2, 2021

The build fails while building the Theia app. From the error message it looks like you may be missing make on your system?
Can you please check the prerequisites of Theia and retry?
Thanks!

@dynamic-modeller
Copy link
Author

Doh!!! Sorry about that, I
glspRepoYarnError2.txt
added the commands
sudo apt-get install build-essential and
sudo apt-get install libx11-dev libxkbfile-dev
according to the prerequisites, but i'm still getting a fail on
cd client && yarn && cd ..

Check out the new text file with the three commands above, the first two work and the last one doesn't, again.

what am i doing wrong?

@planger
Copy link
Member

planger commented Jun 2, 2021

Great that you now get further! These are linting errors, which is surprising.
@tortmayr Do you know why there are happening?

@tortmayr
Copy link
Contributor

tortmayr commented Jun 2, 2021

I'm not familiar with these issues and we have to look into that.
For now what you could try is to skip the linting process. You can do this by using yarn build instead of pure yarn:
cd client && yarn build && cd ..

@dynamic-modeller
Copy link
Author

dynamic-modeller commented Jun 3, 2021

I tried the yarn build command as you suggested, but it once again failed with errors. There are some possiblities though:

  1. I originally tried to set it up on windows, but one of your script commands calls cp, which fails on windows as the command is copy
  2. I then setup WSL using Debian, built a whole new repo in a different directory, and ran into these problems I have been reporting

I am not sure what to do next, any ideas?
glspRepoYarnError3.txt

I actually have two repos of the same code at the moment, one installed using win 10, one using Debian, so i can test either approach as required

@dynamic-modeller
Copy link
Author

dynamic-modeller commented Jun 7, 2021

After my last effort with WSL, I noticed some errors on my OneDrive to do with incorrect names. As an experiement I decided to try to install the GLSP Minimal example on my local drive (i.e. not in the OneDrive space). As usual, the yarn build command failed with a lot of linting errors.

Looking into these linting errors, it appears that the rules you have set go back too deep in the folder hierarchy, for example consider (import-js/eslint-plugin-import#720 ). Apparently this is due to two things:

  1. yOu are using import/no-unresolved and this will cause a problem
  2. on windows systems one can access directories on a case insensitive basis

Can you change the linting options please????? The casing errors are an artifact from interaction between your settings and the file system. Can you change them please?

Error log attached below
glspRepoYarnError4.txt

Try Googling "Casing of import does not match the underlying filesystem" and you will see what i mean

@tortmayr
Copy link
Contributor

tortmayr commented Jun 7, 2021

Hi, unfortunately there was a bug in our yarn build script and the linting was not correctly skipped. I pushed a fix for this.
Could you please try again using yarn build.
In the meantime I will look into the issues with import/no-unresolved.

eclipse-glsp/glsp-examples@3727e9d

@dynamic-modeller
Copy link
Author

Hi, we are definitely making progress.

The yarn build command appeared to work correctly, and everything looked ok.

Then when i changed directory to client, and tried to run the browser with yarn start:browser, this last step did not work, even though we have now made it [ast the build stage.
glspRepoYarnError5.txt

@planger planger moved this from New to In progress in GLSP kanban Jun 11, 2021
@tortmayr tortmayr moved this from In progress to To do in GLSP kanban Aug 31, 2021
@planger
Copy link
Member

planger commented Oct 27, 2021

This issue got stale and is not reproducible on our end. Feel free to reopen, if there is something for GLSP to change.

@planger planger closed this as completed Oct 27, 2021
GLSP kanban automation moved this from To do to Done Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
GLSP kanban
  
Done
Development

No branches or pull requests

3 participants