Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to Java 17 #2117

Closed
snjeza opened this issue Jun 2, 2022 · 4 comments · Fixed by #2118
Closed

Move to Java 17 #2117

snjeza opened this issue Jun 2, 2022 · 4 comments · Fixed by #2118
Assignees
@snjeza
Labels
build/infra Java 17 priority/Blocker Severe security issue or crash requiring immediate fixing
Milestone
End June 2022

Comments

@snjeza
Copy link
Contributor

snjeza commented Jun 2, 2022

m2e.core requires Java 17

We should move Java LS to Java 17 too.
@rgrunber
Copy link
Contributor

rgrunber commented Jun 2, 2022

Do we just need to update :

diff --git a/org.eclipse.jdt.ls.target/org.eclipse.jdt.ls.tp.target b/org.eclipse.jdt.ls.target/org.eclipse.jdt.ls.tp.target
index 15c7331a..ee6e0cb6 100644
--- a/org.eclipse.jdt.ls.target/org.eclipse.jdt.ls.tp.target
+++ b/org.eclipse.jdt.ls.target/org.eclipse.jdt.ls.tp.target
@@ -42,5 +42,5 @@
            <unit id="org.eclipse.lsp4j.sdk.feature.group" version="0.0.0"/>
         </location>
     </locations>
-    <targetJRE path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-11"/>
-</target>
\ No newline at end of file
+    <targetJRE path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-17"/>
+</target>

@snjeza
Copy link
Contributor Author

snjeza commented Jun 2, 2022

Do we just need to update :

We also have to fix the tests.

@rgrunber rgrunber added Java 17 build/infra priority/Blocker Severe security issue or crash requiring immediate fixing labels Jun 2, 2022
@snjeza snjeza self-assigned this Jun 2, 2022
@rgrunber
Copy link
Contributor

rgrunber commented Jun 3, 2022 •
edited
Loading

Not sure if you ran into this, but it's likely a mockito update is needed : cbeams/bisq@e09d56b
Also, Tycho 2.6.0 is needed to even recognize JavaSE-17 (but may as well us 2.7.0).

  • Need Java 18 to run in builds now
  • For org.mockito.mockito-core 4.x
    • org.mockito.Matchers -> org.mockito.ArgumentMatchers ?
    • org.mockito.runners.MockitoJUnitRunner -> org.mockito.junit.MockitoJUnitRunner

@snjeza
Copy link
Contributor Author

snjeza commented Jun 3, 2022

@rgrunber Thanks. I have updated mockito and tycho.
I have to fix several tests yet

@snjeza snjeza changed the title Move to Java 17 [WIP] Move to Java 17 Jun 3, 2022
@snjeza snjeza changed the title [WIP] Move to Java 17 Move to Java 17 Jun 3, 2022
@snjeza snjeza removed the in progress label Jun 3, 2022
@snjeza snjeza mentioned this issue Jun 3, 2022
Merged
@rgrunber rgrunber added this to the End June 2022 milestone Jun 8, 2022
@issyl0 issyl0 mentioned this issue Jul 2, 2022
Closed
@NoahTheDuke NoahTheDuke mentioned this issue Aug 4, 2022
Closed
@rgrunber rgrunber mentioned this issue Aug 30, 2022
Closed
@codingluke codingluke mentioned this issue Oct 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snjeza snjeza

Labels
build/infra Java 17 priority/Blocker Severe security issue or crash requiring immediate fixing
Projects
None yet
Milestone
End June 2022
Development

Successfully merging a pull request may close this issue.

Move to Java 17 snjeza/eclipse.jdt.ls
2 participants
@snjeza @rgrunber