Adjust Equinox launcher detection for mason-registry packaging.

[Matthew-Burkard]

Was setting up jdtls on my machine (running Fedora 41) and it was failing to find the equinox launcher jar.
I looked in the plugins directory that the script was searching and the jar was named org.eclipse.equinox.launcher.jar.

I updated this script to use that jar and it started working for me.

[eclipse-ls-bot]

Can one of the admins verify this patch?

[rgrunber]

Is this org.eclipse.equinox.launcher.jar a symbolic link somewhere on the system ? Was this a version of JDT-LS you downloaded yourself ? Is it from the mason-registry ? If not where from ?

As far as I know we only ship bundles that wouldn't contain at least a version number, and in many cases a qualifier. I think I just need to understand what the new structure of the installation is so I can understand why it's failing.

[Matthew-Burkard]

org.eclipse.equinox.launcher.jar was not a symbolic link, I installed it using mason through the nvim-lspconfig plugin in nvim.

First thing I tired was updating the glob to launcher* instead of launcher_* but it sill found the wrong jar, think the first match was for macos.

Just confirmed from uninstall and re-install from Mason through nvim-lspconfig that the org.eclipse.equinox.launcher.jar is made under plugins.

[rgrunber]

I think adding an extra check to work with the versionless equinox launcher is easy enough but just some concerns :

According to https://github.com/mason-org/mason-registry/blob/main/CONTRIBUTING.md#share & https://github.com/mason-org/mason-registry/blob/main/packages/jdtls/package.yaml#L38-L42 , org.eclipse.equinox.launcher.jar should be a symlink.

My main issue is that renaming the launcher is not enough because we have files like config.ini that reference the versioned jars. So all the post processing mason-registry is doing to rename those jars makes me really surprised any of this is working.

[rgrunber]

@Matthew-Burkard , would you be able to sign the ECA, https://www.eclipse.org/legal/eca/ ? I think it's the only remaining requirement.

[Matthew-Burkard]

@Matthew-Burkard , would you be able to sign the ECA, https://www.eclipse.org/legal/eca/ ? I think it's the only remaining requirement.

I updated the author email of the commit to the one I used when signing the ECA.

[rgrunber]

I've manually verified that you have a signed ECA on file with the provided author email. The problem is the committer email is still the previous one :

Author:     Matthew Burkard <matthewjburkard@gmail.com>
AuthorDate: Fri Feb 7 20:33:18 2025 -0500
Commit:     Matthew Burkard <matthew@burkard.cloud>
CommitDate: Fri Feb 14 17:45:18 2025 -0500

I suspect that's what the validation doesn't like, but I think this is fine.