Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console - Device Management tabs wrong permission #1677

Closed
Coduz opened this issue May 9, 2018 · 1 comment · Fixed by #1678
Closed

Console - Device Management tabs wrong permission #1677

Coduz opened this issue May 9, 2018 · 1 comment · Fixed by #1678
Assignees
Labels
Bug This is a bug or an unexpected behaviour. Fix it! Console GWT This issue/PR is related to Admin Web Console

Comments

@Coduz
Copy link
Contributor

Coduz commented May 9, 2018

Hi all,

currently the permission checked to show or hide the Device Management tabs in the Device view are wrong and a user with device:read permission is allowed to see the Device Management tabs that should require device_management permission.

Regards ,

Alberto

@Coduz Coduz added Bug This is a bug or an unexpected behaviour. Fix it! Console GWT This issue/PR is related to Admin Web Console labels May 9, 2018
@Coduz Coduz self-assigned this May 9, 2018
@LeoNerdoG
Copy link
Contributor

Hey @Coduz,
I did not notice this before, but this is part of issue #1432 which you reported and Bojan made a fix in PR #1672. I have also mentioned you in that PR to check if everything is OK =)
So there is no need for your PR (as @bojanutkovic PR contains this and other fixes for permissions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it! Console GWT This issue/PR is related to Admin Web Console
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants