Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Job-Engine-Service Cucumber Integration Tests #2662

Closed
LeoNerdoG opened this issue Jul 19, 2019 · 1 comment
Closed

No Job-Engine-Service Cucumber Integration Tests #2662

LeoNerdoG opened this issue Jul 19, 2019 · 1 comment
Labels
Test Test related stuff. It's a dirty job, but someone needs to do that!

Comments

@LeoNerdoG
Copy link
Contributor

For now, we do not have any job-engine-service cucumber integration tests. We should add tests online device, offline device, multiple devices and for all the possible steps (command execution, Configuratio put...) to check if everything is OK.

We will devide scenarios in multiple Pull Requests to avoid CQ (I think this is not necessary for integration tests).

Testflow:
/

Expected behavior
We should add integration tests for job-engine-service, because there are none.

Screenshots
/

Version of Kapua
1.1.0 - Snapshot

Type of deployment
/

Main component affected
/

Additional context
/

@Coduz Coduz added the Test Test related stuff. It's a dirty job, but someone needs to do that! label Jul 23, 2019
@LeoNerdoG
Copy link
Contributor Author

Based on the PRs that have been merged (see above) and now that the "reafctoring" PR is also merged and tests are stable, I am closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Test related stuff. It's a dirty job, but someone needs to do that!
Projects
None yet
Development

No branches or pull requests

2 participants