Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test what causing the test failure #1459

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Jun 27, 2023

  • add message changes

@github-actions
Copy link

github-actions bot commented Jun 27, 2023

Test Results

106 files  ±0  106 suites  ±0   10m 23s ⏱️ +15s
657 tests ±0  646 ✔️  - 1  10 💤 ±0  1 +1 
657 runs  ±0  645 ✔️  - 1  11 💤 ±0  1 +1 

For more details on these failures, see this check.

Results for commit 3de5fcd. ± Comparison against base commit 2adb5ac.

♻️ This comment has been updated with latest results.

@laeubi
Copy link
Member Author

laeubi commented Jun 27, 2023

It seems the new dependency causing the test-failure that's really strange...

@laeubi
Copy link
Member Author

laeubi commented Jun 27, 2023

@mickaelistria any idea why the test is sensitive to the imports in the manifest?

@mickaelistria
Copy link
Contributor

It may be some activation ordering or something of that sort. For instance with VM detection in JDT, some tests have started to fail because it induced a change in preference initialization order.

@laeubi
Copy link
Member Author

laeubi commented Jun 27, 2023

I can run the project when importing it into a runtime-m2e... it also seem to not test m2e but running a java program directly, so this is mystery....

@HannesWell
Copy link
Contributor

@laeubi is this still relevant?

@laeubi
Copy link
Member Author

laeubi commented Aug 23, 2023

Yes this is still relevant unless someone can explain why we get a test failure for a completely unrelated change.

Adding org.eclipse.core.variables to the manifest let the test org.eclipse.m2e.jdt.tests.RunTest#testRunTwice fail for no obvious reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants