Stop jarsigning #1862
Merged
Stop jarsigning #1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 321 files 321 suites 49m 15s ⏱️ For more details on these failures and errors, see this check. Results for commit 9f6fe43. ♻️ This comment has been updated with latest results. |
PGP sign is enough, simrel no longer requires jarsigning and build becomes faster and more stable without the network roadtrips caused by eclipse-jarsigner.
|
@laeubi are you fine with this? |
|
I have no concerns. |
|
Merging in this case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PGP sign is enough, simrel no longer requires jarsigning and build becomes faster and more stable without the network roadtrips caused by eclipse-jarsigner.