Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for release 4.35 #1489

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Update for release 4.35 #1489

merged 2 commits into from
Nov 23, 2024

Conversation

github-actions[bot]
Copy link

A new release milstone was created, please review the changes and merge if appropriate.

Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to fix the gitignore first and not include the content from the target folder!

Will look into it this evening.

@HannesWell
Copy link
Member

We have to fix the gitignore first and not include the content from the target folder!

See #1490.

@MohananRahul or @gireeshpunathil should I submit #1490 and rebase this and remove the unintended additions or should I wait with that? I don't want to disturb the preparation process.

@HannesWell HannesWell dismissed their stale review November 22, 2024 22:42

Unwanted addition of files is removed.

@HannesWell
Copy link
Member

The addition of MANIFEST.MF files from the maven target folder is now removed and the parent version bumps are looking good.
But what's missing are the corresponding version bumps that are necessary because the affected projects are changed for the first time in the new dev-cycle.

Copy link
Author

github-actions bot commented Nov 23, 2024

Test Results

   285 files  ±0     285 suites  ±0   52m 3s ⏱️ - 4m 2s
 3 586 tests ±0   3 510 ✅ ±0   76 💤 ±0  0 ❌ ±0 
10 950 runs  ±0  10 719 ✅ ±0  231 💤 ±0  0 ❌ ±0 

Results for commit 7d78728. ± Comparison against base commit b74719a.

♻️ This comment has been updated with latest results.

@akurtakov akurtakov merged commit 026b764 into master Nov 23, 2024
18 checks passed
@akurtakov akurtakov deleted the update_R4.35 branch November 23, 2024 08:04
@akurtakov
Copy link
Member

Merging with manual version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants