Add jakarta.servlet-api, javax.servlet.jsp-api, javax.el-api to isv. #1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The javadoc build seems to need them. eclipse-platform#1361
|
I've already merged this. Shall I kick of yet another I-Build? |
Yes, please. |
|
Thanks, that solved javadoc compilation errors. |
|
Thank you for the confirmation! This is also a good reminder that garbage cleaning the target platform is not a trivial task... |
|
I'm a bit late here but there must be smth else in the target platform that provides these apis so code compiles which could have been added to the scripts/config instead. Not that it matters as the way they are used here is just at generation time so whatever works but I had to share that for if/when someone faces similar problem in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The javadoc build seems to need them.
#1361