Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UInt32 datatype in long_value or int_value? #102

Closed
jbrzozoski opened this issue Jun 28, 2021 · 1 comment
Closed

UInt32 datatype in long_value or int_value? #102

jbrzozoski opened this issue Jun 28, 2021 · 1 comment
Assignees
@wes-johnson

Comments

@jbrzozoski
Copy link

How to properly transport a UInt32 datatype disagrees between the spec and the reference implementation. Chapter 6, section 6.4.17 contains:

** _UInt32_
*** Unsigned 32-bit integer
*** Google Protocol Buffer Type: uint32
*** Sparkplug enum value: 7

That says that a UInt32 datatype value should go in a protobuf type of uint32, yet the reference implementation and Ignition both use the "uint64 long_value" field.
@wes-johnson wes-johnson self-assigned this May 3, 2022
@wes-johnson wes-johnson mentioned this issue Jun 9, 2022
Merged
@wes-johnson
Copy link
Contributor

This is fixed per: eclipse-tahu/tahu#202.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wes-johnson wes-johnson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wes-johnson @jbrzozoski