From b33ab2cd5e9044c94533822f12d7f9d01a30e822 Mon Sep 17 00:00:00 2001 From: FernandoAscencio <48699277+FernandoAscencio@users.noreply.github.com> Date: Wed, 29 Mar 2023 14:08:57 -0400 Subject: [PATCH 1/4] theming: default set to `theia-file-icons` (#12346) The commit sets the default file-icon theme to `theia-file-icons` instead of `none`. Signed-off-by: FernandoAscencio --- CHANGELOG.md | 1 + dev-packages/application-package/src/application-props.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 804a5f7288d10..3ce50705d99dd 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ [Breaking Changes:](#breaking_changes_1.36.0) +- [core] changed default icon theme from `none` to `theia-file-icons` [#11028](https://github.com/eclipse-theia/theia/pull/12346) - [plugin] renamed `TreeViewExtImpl#toTreeItem()` to `TreeViewExtImpl#toTreeElement()` - [scm] Fixing 'scm' inline commands, introduces the following breaking changes: [#12295](https://github.com/eclipse-theia/theia/pull/12295) - Interface ScmInlineAction removes 'commands: CommandRegistry' diff --git a/dev-packages/application-package/src/application-props.ts b/dev-packages/application-package/src/application-props.ts index 7b1310c152f5e..7b0d0504145cd 100644 --- a/dev-packages/application-package/src/application-props.ts +++ b/dev-packages/application-package/src/application-props.ts @@ -70,7 +70,7 @@ export namespace FrontendApplicationConfig { export const DEFAULT: FrontendApplicationConfig = { applicationName: 'Eclipse Theia', defaultTheme: { light: 'light', dark: 'dark' }, - defaultIconTheme: 'none', + defaultIconTheme: 'theia-file-icons', electron: ElectronFrontendApplicationConfig.DEFAULT, defaultLocale: '', validatePreferencesSchema: true From b08dd9d6d2b62889526eebe5dba2cb3f90b467f3 Mon Sep 17 00:00:00 2001 From: Timon Jurschitsch <103483059+DerTimonius@users.noreply.github.com> Date: Thu, 30 Mar 2023 02:54:20 +0200 Subject: [PATCH 2/4] core: fix `waitForHidden` method (#12300) The commit fixes an issue with the `waitForHidden` method to actually check for proper visibility. The previous implementation would wait for the widget to be visible rather than non-visible. --- packages/core/src/browser/widgets/widget.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/src/browser/widgets/widget.ts b/packages/core/src/browser/widgets/widget.ts index b436811327927..02af3612c6fd8 100644 --- a/packages/core/src/browser/widgets/widget.ts +++ b/packages/core/src/browser/widgets/widget.ts @@ -333,7 +333,7 @@ export function waitForRevealed(widget: Widget): Promise { * Resolves when the given widget is hidden regardless of attachment. */ export function waitForHidden(widget: Widget): Promise { - return waitForVisible(widget, true); + return waitForVisible(widget, false); } function waitForVisible(widget: Widget, visible: boolean, attached?: boolean): Promise { From 3a2e796032a65d5d82df84fde19bb1f48fdd4ec2 Mon Sep 17 00:00:00 2001 From: Remi Schnekenburger Date: Thu, 30 Mar 2023 01:20:17 -0700 Subject: [PATCH 3/4] vscode: bump default api to 1.72.2 (#12359) Contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger --- dev-packages/application-package/src/api.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev-packages/application-package/src/api.ts b/dev-packages/application-package/src/api.ts index 9e1a8cb6dbee5..84df6aa0137f9 100644 --- a/dev-packages/application-package/src/api.ts +++ b/dev-packages/application-package/src/api.ts @@ -18,4 +18,4 @@ * The default supported API version the framework supports. * The version should be in the format `x.y.z`. */ -export const DEFAULT_SUPPORTED_API_VERSION = '1.70.2'; +export const DEFAULT_SUPPORTED_API_VERSION = '1.72.2'; From 99b8648c47faaf7aa76ae20ba12081efaad7ac4d Mon Sep 17 00:00:00 2001 From: FernandoAscencio <48699277+FernandoAscencio@users.noreply.github.com> Date: Thu, 30 Mar 2023 04:40:17 -0400 Subject: [PATCH 4/4] QuickInput: Error Message on File not Found (#12255) Fixes an issue where the error message did not render when file not found. Signed-off-by: FernandoAscencio --- packages/file-search/src/browser/quick-file-open.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/file-search/src/browser/quick-file-open.ts b/packages/file-search/src/browser/quick-file-open.ts index cd24fc11e63a0..225279b63eda2 100644 --- a/packages/file-search/src/browser/quick-file-open.ts +++ b/packages/file-search/src/browser/quick-file-open.ts @@ -278,7 +278,10 @@ export class QuickFileOpenService implements QuickAccessProvider { widget.editor.restoreViewState(closedEditor.viewState); } }) - .catch(error => this.messageService.error(error)); + .catch(error => { + console.warn(error); + this.messageService.error(nls.localizeByDefault("Unable to open '{0}'", uri.path.toString())); + }); } protected buildOpenerOptions(): EditorOpenerOptions {