Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode default API is Theia API #10190

Closed
tsmaeder opened this issue Sep 29, 2021 · 0 comments
Closed

VSCode default API is Theia API #10190

tsmaeder opened this issue Sep 29, 2021 · 0 comments
Labels
plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility

Comments

@tsmaeder
Copy link
Contributor

Bug Description:

When a module require()s vscode, we try to find the plugin the request is made from. If we can't determine the plugin, we return a "default" API. In eclipse-che/che#18219, we're hitting this case. The problem is that we mangle the Theia API to look like the vscode API in the normal case, but not for the default API. This means that in particular vscode.extensions is not defined.

Steps to Reproduce:

t.b.d.

Additional Information

  • Operating System:
  • Theia Version:
@vince-fugnitto vince-fugnitto added plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility labels Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

2 participants