Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scm: history does not work when using builtin vscode extensions #10786

Closed
vince-fugnitto opened this issue Feb 23, 2022 · 4 comments
Closed

scm: history does not work when using builtin vscode extensions #10786

vince-fugnitto opened this issue Feb 23, 2022 · 4 comments
Labels
bug bugs found in the application git issues related to git scm issues related to the source control manager

Comments

@vince-fugnitto
Copy link
Member

Bug Description:

The scm-history view does not work when using the vscode builtin extensions, there is a message stating that history does not work for git source control (the same is true when an individual file is selected to display it's history):

image

Steps to Reproduce:

  1. remove @theia/git from the example application(s)

  2. use the git builtins (tested with 1.53.2):

    "vscode-git": "https://open-vsx.org/api/vscode/git/1.53.2/file/vscode.git-1.53.2.vsix",
    "vscode-git-ui": "https://open-vsx.org/api/vscode/git-ui/1.53.2/file/vscode.git-ui-1.53.2.vsix"
  3. start the application with a folder that is under version control

  4. confirm that version control works (scm-view), but not the history view

@vince-fugnitto vince-fugnitto added bug bugs found in the application git issues related to git scm issues related to the source control manager labels Feb 23, 2022
@vince-fugnitto
Copy link
Member Author

It looks like it was never actually supported #6381, the vscode api for extensions does not provide history, but it does provide timeline information. I believe it was the reason to have some @theia/scm-extra (which I had forgotten about).

@msujew I believe there is no issue, if we use the builtin we should not use @theia/git or @theia/scm-extra.

@danepowell
Copy link
Contributor

if we use the builtin we should not use @theia/git or @theia/scm-extra

Since the Theia Blueprint uses the builtin Git extension instead of @theia/git, does that mean it should remove @theia/scm and @theia/scm-extra? I'm happy to open a PR if so.

@vince-fugnitto
Copy link
Member Author

Since the Theia Blueprint uses the builtin Git extension instead of @theia/git, does that mean it should remove @theia/scm and @theia/scm-extra? I'm happy to open a PR if so.

@danepowell @theia/scm is necessary is necessary for source-control support in which vscode.git is a contribution. The @theia/scm-extra can be safely removed I believe as it only contributes the history-view at this time.

@danepowell
Copy link
Contributor

Thanks; PR to remove scm-extra: eclipse-theia/theia-ide#293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application git issues related to git scm issues related to the source control manager
Projects
None yet
Development

No branches or pull requests

2 participants