Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick file open labels are not localized #12570

Closed
Zebsterpasha opened this issue May 26, 2023 · 0 comments · Fixed by #12571
Closed

Quick file open labels are not localized #12570

Zebsterpasha opened this issue May 26, 2023 · 0 comments · Fixed by #12571
Labels
localization issues related to localization/internalization/nls

Comments

@Zebsterpasha
Copy link
Contributor

Bug Description:

Steps to Reproduce:

  1. Press "Ctrl + P" , find some file, open it
  2. Press "Ctrl + P" again and you see label "recently opened"
  3. This label is not localized
  4. The same situation with label "file results"

theia/packages/file-search/src/browser/quick-file-open.ts

Line 171 in c1a2b7b

recentlyUsedItems.push({ type: 'separator', label: 'recently opened' });

theia/packages/file-search/src/browser/quick-file-open.ts

Line 201 in c1a2b7b

result.push({ type: 'separator', label: 'file results' });

Additional Information

  • Operating System: Any
  • Theia Version: Latest
@Zebsterpasha Zebsterpasha mentioned this issue May 26, 2023
Merged
1 task
@vince-fugnitto vince-fugnitto added the localization issues related to localization/internalization/nls label May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
localization issues related to localization/internalization/nls
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

12570 Localized quick file open labels Zebsterpasha/theia
2 participants
@vince-fugnitto @Zebsterpasha