Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS code tree view context menu using view/item/context does not show properly #13213

Closed
umar-shabbir opened this issue Dec 26, 2023 · 2 comments

Comments

@umar-shabbir
Copy link

umar-shabbir commented Dec 26, 2023

Bug Description:

Adding custom context menu entries to a tree view using view/item/context in package.json does not work properly. The custom entry for context menu does not show properly and is barely visible in the UI. This means that menu item is being created but there is some bug with its UI rendering.
A screenshot from Theia and VS code is attached. Please see the difference how edit icon is appearing in both places.

Steps to Reproduce:

  1. Package a .vsix of VS code tree view sample or use the attached .vsix file from custom-view-samples-0.0.1.zip
  2. Run browser example app from Theia repository and install tree view sample .vsix
  3. Open any folder in editor which contains a package.json file
  4. Open package explorer from activity bar and hover on right side (where inline menu items are displayed) of any package
  5. Notice the visibility of edit menu item

Additional Information

Left side is Theia browser app. Right side is VS code extension development host preview
theia-treeview-context-edit

Tree view sample:
custom-view-samples-0.0.1.zip

  • Operating System: Windows 11
  • Theia Version: 1.44.0
@JonasHelming
Copy link
Contributor

@rschnekenbu

@rschnekenbu
Copy link
Contributor

On master branch, the icons are now visible. They were indeed missing in version 1.44.0.
This bug can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants