Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theia attempts to open notebooks as editors (and fails) #13404

Closed
msujew opened this issue Feb 21, 2024 · 1 comment
Closed

Theia attempts to open notebooks as editors (and fails) #13404

msujew opened this issue Feb 21, 2024 · 1 comment
Labels
bug bugs found in the application monaco issues related to monaco notebook issues related to notebooks

Comments

@msujew
Copy link
Member

msujew commented Feb 21, 2024

Bug Description:

After #13217, I've noticed that when editing a notebook file for the first time (thereby setting its state to dirty), Theia will attempt to open the file as a normal monaco editor, which then fails:

image

Steps to Reproduce:

  1. Open a notebook widget
  2. Edit a cell
  3. The error should appear in the console
@msujew msujew added bug bugs found in the application monaco issues related to monaco notebook issues related to notebooks labels Feb 21, 2024
@msujew
Copy link
Member Author

msujew commented Aug 5, 2024

This doesn't seem to happen anymore. Likely due to improvements in Monaco & Notebook handling.

@msujew msujew closed this as completed Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application monaco issues related to monaco notebook issues related to notebooks
Projects
None yet
Development

No branches or pull requests

1 participant