Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fine-grained CSS variables #1486

Closed
akosyakov opened this issue Mar 13, 2018 · 4 comments · Fixed by #6475
Closed

fine-grained CSS variables #1486

akosyakov opened this issue Mar 13, 2018 · 4 comments · Fixed by #6475
Assignees
Labels
theming issues related to theming

Comments

@akosyakov
Copy link
Member

akosyakov commented Mar 13, 2018

We use CSS variables for theming. Right now most of the variables are generic and changing them can break some parts of UI. It would be nice to introduce semantic specific CSS variables to have more fine-grained control.

@akosyakov akosyakov added the theming issues related to theming label Mar 13, 2018
@svenefftinge
Copy link
Contributor

I don't think they should be extension specific, but they should be semantic. I.e. naming common UI elements, like we started doing with the scrollbar, buttons and dialogs already.

@spoenemann
Copy link
Contributor

@akosyakov how is this related to #1504? Do you propose to replace the existing variables using new names, or to add new variables in addition to the existing ones?

@akosyakov
Copy link
Member Author

No, it is not related, it is about adding new variables.

@spoenemann
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theming issues related to theming
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants