Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[search in workspace] For replace use more generalised solution #1788

Closed
jbicker opened this issue Apr 26, 2018 · 1 comment
Closed

[search in workspace] For replace use more generalised solution #1788

jbicker opened this issue Apr 26, 2018 · 1 comment
Labels
quality issues related to code and application quality search in workspace issues related to the search-in-workspace

Comments

@jbicker
Copy link
Contributor

jbicker commented Apr 26, 2018 •
edited
Loading

Depends on #1756
After it is solved we should use that instead of https://github.com/theia-ide/theia/blob/SearchAndReplaceInWorkspace/packages/editor/src/browser/editor.ts#L89
@jbicker jbicker mentioned this issue Apr 26, 2018
Merged
@jbicker jbicker added quality issues related to code and application quality search in workspace issues related to the search-in-workspace labels Apr 26, 2018
@akosyakov akosyakov mentioned this issue Jul 9, 2018
Closed
@FernandoAscencio
Copy link
Contributor

Is this still an issue?
The link to code now gives a 404 error message and Issue 1756 seems to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
quality issues related to code and application quality search in workspace issues related to the search-in-workspace
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbicker @vince-fugnitto @FernandoAscencio