Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[monaco] Integrate with menus / commands #22

Closed
3 tasks done
svenefftinge opened this issue Apr 3, 2017 · 4 comments
Closed
3 tasks done

[monaco] Integrate with menus / commands #22

svenefftinge opened this issue Apr 3, 2017 · 4 comments

Comments

@svenefftinge
Copy link
Contributor

svenefftinge commented Apr 3, 2017

  • The actions provided by monaco should be registered with our CommandRegistry.
  • A context menu for monaco editors should be registered with MenuModelRegistry.
  • monaco context menu should be deactivated and replaced with ours
kittaakos added a commit that referenced this issue Apr 4, 2017
Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos added a commit that referenced this issue Apr 4, 2017
Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos added a commit that referenced this issue Apr 5, 2017
Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos added a commit that referenced this issue Apr 5, 2017
Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos added a commit that referenced this issue Apr 5, 2017
Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos added a commit that referenced this issue Apr 5, 2017
kittaakos added a commit that referenced this issue Apr 5, 2017
Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos added a commit that referenced this issue Apr 5, 2017
Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos added a commit that referenced this issue Apr 5, 2017
Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos added a commit that referenced this issue Apr 10, 2017
kittaakos added a commit that referenced this issue Apr 10, 2017
Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos added a commit that referenced this issue Apr 10, 2017
Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos added a commit that referenced this issue Apr 10, 2017
Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos added a commit that referenced this issue Apr 11, 2017
Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos added a commit that referenced this issue Apr 11, 2017
Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos added a commit that referenced this issue Apr 11, 2017
Signed-off-by: Akos Kitta <kittaakos@gmail.com>
@kittaakos
Copy link
Contributor

kittaakos commented Apr 12, 2017

During a short investigation, Google Docs, LucidChart and Cloud9 IDE were examined. It turned out; there is no ultimate solution for accessing the native clipboard from the browser, so to support the copy/cut/paste actions in all major browsers, we would need to have browser specific implementations.

We decided to follow the Monaco pattern and support the main- and context menu based copy/cut/paste only in the Electron-based application.

Here comes a list of threads which provide more information on the native clipboard access.

@kittaakos
Copy link
Contributor

kittaakos commented Apr 12, 2017

It would be great to show the associated key binding for a command in the (context-) menu if any. Just like Monaco does here.

Moved to #37.

kittaakos added a commit that referenced this issue Apr 12, 2017
Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos added a commit that referenced this issue Apr 12, 2017
Signed-off-by: Akos Kitta <kittaakos@gmail.com>
@kittaakos
Copy link
Contributor

kittaakos added a commit that referenced this issue Apr 13, 2017
But not the menu contribution.

Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos added a commit that referenced this issue Apr 13, 2017
GH-22 [monaco] Integrate with menus / commands
@kittaakos
Copy link
Contributor

Closed via #35.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants