Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hosted plugin leaking json rpc proxy factories #3523

Closed
akosyakov opened this issue Nov 16, 2018 · 2 comments
Closed

hosted plugin leaking json rpc proxy factories #3523

akosyakov opened this issue Nov 16, 2018 · 2 comments
Assignees
@vitaliy-guliy
Labels
performance issues related to performance plug-in system issues related to the plug-in system Team: Che-Editors issues regarding the che-editors team

Comments

@akosyakov
Copy link
Member

akosyakov commented Nov 16, 2018 •
edited
Loading

screen shot 2018-11-16 at 12 18 51

To reproduce:

  • start Theia with several pages
  • close all pages
  • take the memory snapshot of the backend
  • look for JsonRpcProxyFactory which is retained by the hosted plugin process even though clients are gone
@akosyakov akosyakov added performance issues related to performance plug-in system issues related to the plug-in system labels Nov 16, 2018
@akosyakov akosyakov mentioned this issue Nov 16, 2018
Merged
@evidolob evidolob mentioned this issue Feb 27, 2019
Closed
40 tasks
@evidolob evidolob added the Team: Che-Editors issues regarding the che-editors team label Feb 27, 2019
@ashumilova ashumilova mentioned this issue Mar 12, 2019
Closed
36 tasks
@vitaliy-guliy vitaliy-guliy self-assigned this Mar 13, 2019
@vitaliy-guliy
Copy link
Contributor

@akosyakov It looks we don't have the leakage anymore.Having spent some time on debugging and profiling the backend, I haven't found it.
Let you see at following snapshots.
The first one I got before opening browser tabs, second displays state with 4 tabs and the last one I take after closing the browser.

snapshot 1

snapshot 2

snapshot 3

@akosyakov
Copy link
Member Author

sounds good, thanks for checking!

probably resolved by #4521, since a hosted plugin process should be garbage collected now when a connection is closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitaliy-guliy vitaliy-guliy

Labels
performance issues related to performance plug-in system issues related to the plug-in system Team: Che-Editors issues regarding the che-editors team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@evidolob @vitaliy-guliy @akosyakov