Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal] add 'References' widget #4784

Closed
vince-fugnitto opened this issue Apr 2, 2019 · 7 comments
Closed

[proposal] add 'References' widget #4784

vince-fugnitto opened this issue Apr 2, 2019 · 7 comments
Labels
enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility

Comments

@vince-fugnitto
Copy link
Member

I propose we implement and introduce the References widget in Theia.

Screenshot from 2019-04-02 09-12-11

The widget (triggered by the Find All References command) offers a more persistent option as compared to the Peek References command. It opens the search results in a designated widget as compared to the peek, and is great for todo lists. Since it is a widget, it is also possible to save it's state in local storage to easily be able to recover on startup.

@vince-fugnitto vince-fugnitto added the enhancement issues that are enhancements to current functionality - nice to haves label Apr 2, 2019
@akosyakov
Copy link
Member

We should use vscode extension: https://github.com/Microsoft/vscode-references-view

@vince-fugnitto
Copy link
Member Author

We should use vscode extension: https://github.com/Microsoft/vscode-references-view

Oh great! It looks like its the official extension and is shipped with vscode, it'd be great to try it in Theia :)

@akosyakov
Copy link
Member

But there are many missing things yet to run it:

  ],
  "missingSymbols": [
    "\"vscode\".Clipboard",
    "\"vscode\".Clipboard.writeText",
    "\"vscode\".ThemeIcon.File",
    "\"vscode\".TreeItem.description",
    "\"vscode\".TreeView.message",
    "\"vscode\".TreeView.onDidChangeVisibility",
    "\"vscode\".TreeView.visible",
    "\"vscode\".TreeViewVisibilityChangeEvent",
    "\"vscode\".TreeViewVisibilityChangeEvent.visible",
    "\"vscode\".env.clipboard"
  ],
  "missingCommands": [
    "editor.action.showReferences",
    "editor.findMatchHighlightBackground",
    "vscode.executeReferenceProvider"
  ],
  "dynamicCommanCalls": [
    "`${viewId}.focus` (/workspace/vscode-references-view/src/extension.ts 58:39)"
  ]

Someone has to look into them. Complete TreeView interface would be the easiest to start.

@akosyakov akosyakov added help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility labels Apr 2, 2019
@tsmaeder
Copy link
Contributor

TreeView.message and the commands "editor.findMatchingHighlightBackground" and "vscode.executeReferenceProvider" seem to be missing, the rest seems to work in master as of today

@tsmaeder
Copy link
Contributor

See in plugin-vscode-commands-contribution.ts

@tsmaeder
Copy link
Contributor

tsmaeder commented Nov 6, 2019

Btw: view.message is the text that shows "20 results in 12 files" at the top of the view.

@akosyakov
Copy link
Member

resolved by #7055

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

3 participants