Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy pasting a file in the same directory #4794

Closed
toonvd opened this issue Apr 2, 2019 · 9 comments
Closed

Copy pasting a file in the same directory #4794

toonvd opened this issue Apr 2, 2019 · 9 comments
Labels
ui/ux issues related to user interface / user experience

Comments

@toonvd
Copy link
Contributor

toonvd commented Apr 2, 2019

Description

Copy pasting a file in the same directory should either rename it (.1, .2) or ask for a new name before adding it. In the browser I get either "Please use the browser's paste command or shortcut." or nothing.

Reproduction Steps

Copy paste

OS and Theia version:
Ubuntu v0.5.0

@toonvd
Copy link
Contributor Author

toonvd commented Apr 2, 2019

I know the duplicate option exists, maybe it could be possible to trigger this action in this particular case?

@vince-fugnitto
Copy link
Member

Yes, I just verified and calling the duplicate might be the way to go, it'll handle creating a unique URI (example: a.py to a_copy.py). That seems to align with how VSCode treats the copy pasting in the same directory.

@vince-fugnitto
Copy link
Member

@toonvd also, do you think the behavior of duplicate should be modified?

  1. a.py to a.1.py (VSCode way)
  2. a.py to a_copy.py (Theia way)

@toonvd
Copy link
Contributor Author

toonvd commented Apr 2, 2019

It would be nice if we could align this, if you duplicate it multiple times it adds _2 anyways.
I could take a look at this on sunday. But need to familiarize myself with the core first.

@vince-fugnitto
Copy link
Member

It would be nice if we could align this, if you duplicate it multiple times it adds _2 anyways.
I could take a look at this on sunday. But need to familiarize myself with the core first.

Sure, I can help you out if you ever have any questions

@akosyakov
Copy link
Member

In the browser I get either "Please use the browser's paste command or shortcut." or nothing.

@toonvd Is it confusing somehow? The issue is that your browser does not support programmatic paster, so we cannot trigger it from the code. Only you can do it via browser menu -> paste.

@akosyakov akosyakov added the ui/ux issues related to user interface / user experience label Apr 3, 2019
@toonvd
Copy link
Contributor Author

toonvd commented Apr 3, 2019

Hi @akosyakov

The problem was I tested it via browser menu -> paste and it still did not have the desired effect. EG, copy paste of a file in the same folder should result in a duplicate like in VSCode. The "Please use the browser's paste command or shortcut." warning itself was clear enough for me.

P.s. mentioned Vince by accident :3

@akosyakov
Copy link
Member

ok, if you align it with VS Code it would be great

@msujew
Copy link
Member

msujew commented Dec 16, 2022

I believe this has been fixed by #10767.

@msujew msujew closed this as completed Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux issues related to user interface / user experience
Projects
None yet
Development

No branches or pull requests

4 participants