-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the logger accessible outside the inversify context #517
Comments
@svenefftinge @akosyakov We need to do this for other things too like the MessageTranslation class in the globalize PR. However I don't understand where we would export a global variable from the container. It looks like the correct place would be in src-gen/server.ts for example where the container is created but that doesn't make sense since a package won't be able to import that... Any ideas on this ? |
I think it would be a side-effect on an existing global when the container is created. |
Haaa yes ok that would work good point thx! :) |
Fixed in #562 |
It would be nice to be able to use the logger outside of the inversify context.
For example in the Globalize PR we would need to do this to avoid using console.log
An idea discussed has been to use a global variable to the logger singleton and bind that to the global console so that any use of console.log goes though our logger.
I would suggest theia's code still use logger.log however
The text was updated successfully, but these errors were encountered: