Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snippet suggestion does not replace the input string #5926

Closed
yeweiasia opened this issue Aug 13, 2019 · 4 comments · Fixed by #5931
Closed

snippet suggestion does not replace the input string #5926

yeweiasia opened this issue Aug 13, 2019 · 4 comments · Fixed by #5931
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help monaco issues related to monaco

Comments

@yeweiasia
Copy link
Contributor

Description

snippet suggestion does not replace the input string, just append snippet to it

Reproduction Steps

autocompletion1

OS and Theia version:
ubuntu 18.04
theia 0.9.0
chrome 76.0.3809.100

Diagnostics:
@akosyakov akosyakov added bug bugs found in the application help wanted issues meant to be picked up, require help monaco issues related to monaco labels Aug 13, 2019
@akosyakov
Copy link
Member

PRs are welcomed! The issue is somewhere here: https://github.com/theia-ide/theia/blob/master/packages/monaco/src/browser/monaco-snippet-suggest-provider.ts#L22

@yeweiasia
Copy link
Contributor Author

aha, I will take a look

@yeweiasia
Copy link
Contributor Author

#5931

This was referenced Aug 13, 2019
Merged
Closed
@yeweiasia
Copy link
Contributor Author

#5963

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help monaco issues related to monaco
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: snippet suggestion does not replace the input string yeweiasia/theia
2 participants
@akosyakov @yeweiasia