Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode] vscode-icons extension doesn't work #6300

Closed
jankeromnes opened this issue Oct 1, 2019 · 8 comments · Fixed by #6475
Closed

[vscode] vscode-icons extension doesn't work #6300

jankeromnes opened this issue Oct 1, 2019 · 8 comments · Fixed by #6475
Assignees
Labels
theming issues related to theming vscode issues related to VSCode compatibility

Comments

@jankeromnes
Copy link
Member

Description

It seems that the vscode-icons extension doesn't work in Theia:

When installing the extension vsicons the icons don't change and this shows up in preferences
image

(from the original issue gitpod-io/gitpod#818)

Reproduction Steps

  1. Install https://github.com/vscode-icons/vscode-icons/releases in Theia
  2. The icons don't change. Also, this error shows up in user preferences:
Property workbench.iconTheme is not allowed

OS and Theia version: master

Diagnostics:

@akosyakov akosyakov added theming issues related to theming vscode issues related to VSCode compatibility labels Oct 1, 2019
@akosyakov akosyakov self-assigned this Oct 1, 2019
@akosyakov
Copy link
Member

VS Code like theming is not supported yet: #4831

@JesterOrNot
Copy link

what would it take to add this feature?

@akosyakov
Copy link
Member

akosyakov commented Oct 16, 2019

It will be delivered in December.

@JesterOrNot
Copy link

K cool!

@akosyakov
Copy link
Member

VS Code icons with One Pro Dark color theme:
Screen Shot 2019-12-19 at 11 51 08

@JesterOrNot
Copy link

Can you show an example repo @akosyakov

@akosyakov
Copy link
Member

@JesterOrNot Do you mean for Gitpod? Unfortunately it is only PR for Theia for now, first it has to be landed here, then Gitpod needs an upgrade to use a new version of Theia. It will happen in January.

@JesterOrNot
Copy link

Ok @akosyakov my bad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theming issues related to theming vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants