Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variable-resolver-service should let clients know if variables cannot be resolved #6333

Open
elaihau opened this issue Oct 7, 2019 · 1 comment
Labels
variable-resolver issues related to the variable-resolver extension

Comments

@elaihau
Copy link
Contributor

elaihau commented Oct 7, 2019

VariableResolverService.resolve() returns undefined if a variable is not defined in Theia. And therefore its clients need extra work to differentiate the following 2 scenarios:

  1. the variable is "resolved as undefined"
  2. the variable is not defined

It would be helpful if such support is added to variable-resolver-service.

This is a follow-up issue suggested in #6331 (comment)

@elaihau elaihau added the variable-resolver issues related to the variable-resolver extension label Oct 7, 2019
@akosyakov
Copy link
Member

akosyakov commented Oct 7, 2019

We should rather treat undefined as impossible value in APIs, i.e. it should not be ever possible to return by resolvers, but a resolver should be able throw an error instead. We should also review each resolver to align error messages and timing with VS Code. Both tasks and debug extensions should be tested.

@akosyakov akosyakov changed the title variable-resolver-service should let clients know if variables are not defined variable-resolver-service should let clients know if variables cannot be resolved Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
variable-resolver issues related to the variable-resolver extension
Projects
None yet
Development

No branches or pull requests

2 participants