You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
VariableResolverService.resolve() returns undefined if a variable is not defined in Theia. And therefore its clients need extra work to differentiate the following 2 scenarios:
the variable is "resolved as undefined"
the variable is not defined
It would be helpful if such support is added to variable-resolver-service.
We should rather treat undefined as impossible value in APIs, i.e. it should not be ever possible to return by resolvers, but a resolver should be able throw an error instead. We should also review each resolver to align error messages and timing with VS Code. Both tasks and debug extensions should be tested.
akosyakov
changed the title
variable-resolver-service should let clients know if variables are not defined
variable-resolver-service should let clients know if variables cannot be resolved
Oct 7, 2019
VariableResolverService.resolve()
returnsundefined
if a variable is not defined in Theia. And therefore its clients need extra work to differentiate the following 2 scenarios:undefined
"It would be helpful if such support is added to
variable-resolver-service
.This is a follow-up issue suggested in #6331 (comment)
The text was updated successfully, but these errors were encountered: