Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webview resource path is incorrect in some cases #6373

Closed
BroKun opened this issue Oct 12, 2019 · 1 comment · Fixed by #6465
Closed

webview resource path is incorrect in some cases #6373

BroKun opened this issue Oct 12, 2019 · 1 comment · Fixed by #6465
Assignees
Labels
bug bugs found in the application plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility webviews issues related to webviews

Comments

@BroKun
Copy link
Member

BroKun commented Oct 12, 2019

Description

We fixed the #5503 problem before, which brought new problems.
On some plugins, such as vscode-python, their webview already contains a base tag.

<base href="vscode-resource:/pathToExtension/">
<script type="text/javascript" src="vscode-resource:/pathToExtensionr/index_bundle.js"></script>

If there is no slash prefix, you will get the wrong path.

webview/pathToExtension/webview/pathToExtension/index_bundle.js

Reproduction Steps

  1. download vscode-python to the plugin directory.
  2. open the interactive python window via a notebook file.

OS and Theia version:
ALL
Theia master branch

Diagnostics:
I can't find a way to support proxy mode in the case of only modifying the front end. I think we can add some configuration to support it.

@BroKun BroKun changed the title web webview resource path is incorrect in some cases Oct 12, 2019
@BroKun BroKun added the plug-in system issues related to the plug-in system label Oct 12, 2019
@akosyakov
Copy link
Member

akosyakov commented Oct 13, 2019

@BroKun i believe it is a dup of #6282 (comment) and we should so something similar to #6282 (comment)

@akosyakov akosyakov added bug bugs found in the application vscode issues related to VSCode compatibility webviews issues related to webviews help wanted issues meant to be picked up, require help labels Oct 13, 2019
@akosyakov akosyakov removed the help wanted issues meant to be picked up, require help label Oct 30, 2019
@akosyakov akosyakov self-assigned this Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility webviews issues related to webviews
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants