plugin metrics breaks application start up in Firefox

[akosyakov]

cc @tsmaeder @JPinkney

It seems FireFox cannot handle parsing some regex patterns. Maybe https://github.com/eclipse-theia/theia/blob/master/packages/plugin-metrics/src/browser/plugin-metrics-creator.ts#L29

[vince-fugnitto]

Lookbehind regexp are not supported in browsers besides Chrome.
The regexp will need to be updated.

[vince-fugnitto]

All non-chrome browsers likely do not start now (verified with Firefox and Safari).

[tsmaeder]

The regex in question is: (?<=Request)(.*?)(?=failed). I don't think it contains anything that could not be rewritten without the negative lookahead.

[vince-fugnitto]

The regex in question is: (?<=Request)(.*?)(?=failed). I don't think it contains anything that could not be rewritten without the negative lookahead.

@tsmaeder would you like to provide a fix for it? I'm really not the best at regexp.
Also without tests, I'm not sure my implementation would be working correctly.

[tsmaeder]

I can have a look tomorrow, not time today.

[tsmaeder]

I'm trying to test a fix, but I never get any failures if I test like described on #6303

[tsmaeder]

@akosyakov @vince-fugnitto any ideas what I'm doing wrong?

[tsmaeder]

Hmh...all of a sudden, it works. Ignore my pleas!

[vince-fugnitto]

@tsmaeder I did see this when testing the original PR:

 language_server_time_count{id="redhat.vscode-yaml" method="textDocument/hover" result="fail"} 0 # HELP language_server_time_sum Sum of time in milliseconds that language server requests take # TYPE language_server_time_sum gauge language_server_time_sum{id="redhat.vscode-yaml" method="textDocument/hover" result="success"} 33.35499999229796 language_server_time_sum{id="redhat.vscode-yaml" method="textDocument/hover" result="failure"} 0

I'm not sure this enough or what to look for.

[tsmaeder]

Simply using /Request(.*)failed/ will not work, because of eager matching. I think I'll just cut off the prefix/postfix.

[vince-fugnitto]

Closed by #6591