Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SelectionRange and SelectionRangeProvider #6623

Closed
tolusha opened this issue Nov 25, 2019 · 2 comments
Closed

Implement SelectionRange and SelectionRangeProvider #6623

tolusha opened this issue Nov 25, 2019 · 2 comments
Assignees
Labels
help wanted issues meant to be picked up, require help languages issue related to languages monaco issues related to monaco Team: Che-Editors issues regarding the che-editors team vscode issues related to VSCode compatibility

Comments

@tolusha
Copy link
Contributor

tolusha commented Nov 25, 2019

Description

css-language-features, html-language-features, json-language-features builtin extensions failed due to unimplemented VS Code API.

https://github.com/Microsoft/vscode/blob/8795a9889db74563ddd43eb0a897a2384129a619/src/vs/vscode.d.ts#L3842
https://github.com/Microsoft/vscode/blob/8795a9889db74563ddd43eb0a897a2384129a619/src/vs/vscode.d.ts#L3863

@tolusha tolusha added the vscode issues related to VSCode compatibility label Nov 25, 2019
@akosyakov
Copy link
Member

akosyakov commented Nov 25, 2019

Right now html and css coming from monaco. It's baked in the generator:

const monacoCssLanguagePath = '${this.resolve('monaco-css', 'release/min')}';
const monacoHtmlLanguagePath = '${this.resolve('monaco-html', 'release/min')}';`)}

We should make it optional somehow. Otherwise there would be duplicate proposals from monaco and vs code built-in extensions.

@vzhukovs
Copy link
Contributor

Implemented via #7534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted issues meant to be picked up, require help languages issue related to languages monaco issues related to monaco Team: Che-Editors issues regarding the che-editors team vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

4 participants