Quickpick doesn't work when items are updated

[DanTup]

I'm trying to test the asExternalUri support using the instructions from @akosyakov at #6465 (comment) (though I'm using the master branch since that PR is now merged).

When the Dart extension opens the device picker (either by trying to launch an app or clicking on the device label in the status bar) the selector appears but it's impossible to select an item (either with the keyboard or the mouse):

[akosyakov]

@DanTup Could I try it somehow?

[DanTup]

Sorry, I should've set something up :)

I tried forking and setting up a branch to more easily repro here, but it seems to stall when starting up

https://github.com/DanTup/theia/tree/picker-test

It's been like that for quite a while (I tried refreshing the page, but it didn't change). It hasn't bound to port 3000 yet so I can't open it to test.

Scratch that - it just finished - I'll post repro notes back shortly...

[DanTup]

Ok, the Dart version didn't repro (I'm not sure what the difference is yet). But here's a Flutter one:

https://gitpod.io/#https://github.com/DanTup/theia/tree/picker-test

If you run that, then open the app on port 3000, open my_flutter_test/lib/main.dart and then click the "Web Server" label in the status bar, it'll show the device picker:

However, you can't select either of these items. I don't know if it's related, but I have this in the dev console:

[DanTup]

Oh ok, I know what's different - for Flutter we update the list after it's been shown (because some work is async, we may add new items to the list). We do this by re-assigning the items property:

https://github.com/Dart-Code/Dart-Code/blob/cf79ce75cd616e6cf9c43bd866d76c9ff6c6bea1/src/shared/vscode/device_manager.ts#L93-L123

This ability was added in VS Code in v1.26:

https://code.visualstudio.com/updates/v1_26#_quickinput-api

(possibly the same time multi-select was added - #5673).