Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file-icons vscode extension does not work #6776

Closed
RDIL opened this issue Dec 20, 2019 · 2 comments · Fixed by #6475
Closed

file-icons vscode extension does not work #6776

RDIL opened this issue Dec 20, 2019 · 2 comments · Fixed by #6475
Assignees
@akosyakov
Labels
theming issues related to theming vscode issues related to VSCode compatibility

Comments

@RDIL
Copy link
Contributor

RDIL commented Dec 20, 2019

https://marketplace.visualstudio.com/items?itemName=file-icons.file-icons doesn't work
@akosyakov akosyakov changed the title Broken Extension file-icons vscode extension does not work Dec 20, 2019
@akosyakov akosyakov added theming issues related to theming vscode issues related to VSCode compatibility labels Dec 20, 2019
@akosyakov
Copy link
Member

We have a PR for it already: #6475

@akosyakov akosyakov self-assigned this Dec 20, 2019
@akosyakov akosyakov mentioned this issue Dec 20, 2019
Merged
54 tasks
@akosyakov
Copy link
Member

Checked against the PR, it works nicely:
Screen Shot 2019-12-20 at 08 57 20

The only issue that theme name is File Icons, and it is the same name which we use for the default Theia file icons theme. I will rename the default theme to something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
theming issues related to theming vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

VS Code like theming (colors and icons) eclipse-theia/theia
2 participants
@akosyakov @RDIL