Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[getting-started] add widget icon to 'getting-started' widget #6783

Closed
vince-fugnitto opened this issue Dec 20, 2019 · 2 comments
Closed

[getting-started] add widget icon to 'getting-started' widget #6783

vince-fugnitto opened this issue Dec 20, 2019 · 2 comments
Assignees
@akosyakov
Labels
bug bugs found in the application getting-started issues related to the getting-started extension theming issues related to theming

Comments

@vince-fugnitto
Copy link
Member

Description

When the default file icons have been changed (#6475), the getting-started widget (which does not have a widget icon), gets a blank square.

Master:

Screen Shot 2019-12-20 at 2 37 59 PM

PR: (#6475 with file-icon changed)

Screen Shot 2019-12-20 at 2 37 41 PM
@vince-fugnitto vince-fugnitto added bug bugs found in the application getting-started issues related to the getting-started extension labels Dec 20, 2019
@vince-fugnitto
Copy link
Member Author

It is likely that any widget that does not have a widget icon will experience a similar issue.

@akosyakov akosyakov self-assigned this Dec 26, 2019
@akosyakov akosyakov added the theming issues related to theming label Dec 26, 2019
@akosyakov
Copy link
Member

It's a bug, icon element should not rendered if an icon is not set.

akosyakov added a commit that referenced this issue Dec 26, 2019
@akosyakov
[theming] fix #6783: don't render an icon element if an icon is not set
269909c 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@akosyakov
[theming] fix eclipse-theia#6783: don't render an icon element if an …
714444d 
…icon is not set

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
bug bugs found in the application getting-started issues related to the getting-started extension theming issues related to theming
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akosyakov @vince-fugnitto