Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[theming] file-icon incorrectly displays extension icon without extension type #6788

Closed
vince-fugnitto opened this issue Dec 23, 2019 · 0 comments
Closed

[theming] file-icon incorrectly displays extension icon without extension type #6788

vince-fugnitto opened this issue Dec 23, 2019 · 0 comments
Labels
theming issues related to theming

Comments

@vince-fugnitto
Copy link
Member

Description

The file-icon is incorrectly displayed for files without an extension.
For instance, the icon for the following file LICENSE is not properly displayed:

Theia

image

VS Code

image

File a is correctly displayed with an icon in the navigator but not in the editor tab:

image

Additional Information
@vince-fugnitto vince-fugnitto added the theming issues related to theming label Dec 23, 2019
akosyakov added a commit that referenced this issue Dec 26, 2019
@akosyakov
[theming] fix #6788: treat URI without ext as a file if there are ico…
5602c75 
…ns matching to name or language

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Dec 27, 2019
@akosyakov
[theming] fix #6788: introduce URIIconReference
7b42a8e 
To distinguis between folder and file URIs.
By default file icons are computed for URIs,
but clients can provide `folder` as an id of `URIIconReference`
to compute folder icons.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@akosyakov
[theming] fix eclipse-theia#6788: introduce URIIconReference
1e58894 
To distinguis between folder and file URIs.
By default file icons are computed for URIs,
but clients can provide `folder` as an id of `URIIconReference`
to compute folder icons.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
theming issues related to theming
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vince-fugnitto