workbench.action.closeActiveEditor command doesn't close a WebviewWidget

[tomer-epstein]

Description

workbench.action.closeActiveEditor command doesn't close a WebviewWidget

Reproduction Steps

Open the 'Getting Started' (Help -> 'Getting Started')
execute workbench.action.closeActiveEditor command.

Diagnostics:
it seems that the reason is that WebviewWidget doesn't implement Navigatable interface.

[amiramw]

@tomer-epstein does it work in VS Code?

[tomer-epstein]

Yes.

[vince-fugnitto]

Open the 'Getting Started' (Help -> 'Getting Started')

Are you referring to the Getting Started from Theia?

[tomer-epstein]

Open the 'Getting Started' (Help -> 'Getting Started')

Are you referring to the Getting Started from Theia?

Yes. it's an example for WebviewWidget.
another vscode extension which opens WebviewWidget is https://github.com/SAP/yeoman-ui

[vince-fugnitto]

Open the 'Getting Started' (Help -> 'Getting Started')

Are you referring to the Getting Started from Theia?

Yes. it's an example for WebviewWidget.
another vscode extension wich opens WebviewWidget is https://github.com/SAP/yeoman-ui

@tomer-epstein
I don't think our Getting Started is a WebviewWidget, what makes you believe it is?
https://github.com/eclipse-theia/theia/blob/master/packages/getting-started/src/browser/getting-started-widget.tsx

[tomer-epstein]

debuging plugin-vscode-commands-contribution

[akosyakov]

In VS Code there is a difference between editor and code editor. Editor is any widget opened in the editor area (main area in Theia). Code editor is Monaco-based widget. So yes, webview is an editor in VS Code sense and closeActiveEditor should close the webview as well.

theia/packages/plugin-ext/src/main/browser/menus/menus-contribution-handler.ts

Line 45 in 9fb6351

export namespace CodeEditorWidget {

is a function which can check whether a given widget is an editor in VS Code sense. We should rewrite all vscode editor commands using it.

[paul-marechal]

PR was merged.