New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workbench.action.closeEditorsInGroup doesn't close it self (the current Widget) #6997

Closed

tomer-epstein opened this issue Jan 29, 2020 · 1 comment · Fixed by #7018

Labels

bug vscode

Contributor

tomer-epstein commented Jan 29, 2020 •

edited

Loading

Description
workbench.action.closeEditorsInGroup command doesn't close it self (the current Widget)

Reproduction Steps
Open couple of files in agroup
execute workbench.action.closeEditorsInGroup command.
Can also be tested with this vscode ext - https://github.com/tomer-epstein/vscode-close-editor.git

Diagnostics:
plugin-vscode-commands-contribution.ts
({ owner }) => CodeEditorWidget.is(owner) && owner !== editor

tomer-epstein mentioned this issue

FIX Issue 6955 - workbench.action.closeActiveEditor command #6978

Merged

1 task

Member

amiramw commented Jan 29, 2020

@tomer-epstein add your vscode that makes it easy to reproduce.

akosyakov added bug vscode labels

tomer-epstein mentioned this issue

FIX Issue 6997 - workbench.action.closeEditorsInGroup command #7018

Merged

1 task

vince-fugnitto closed this as completed in #7018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment